Improve keyboard navigation for all framework #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdanpdan
force-pushed
the
color-datetime-kbd
branch
4 times, most recently
from
8c5af21
to
b3237a9
Compare
pdanpdan
changed the title
pdanpdan
force-pushed
the
color-datetime-kbd
branch
2 times, most recently
from
0520f94
to
c5a296c
Compare
pdanpdan
force-pushed
the
color-datetime-kbd
branch
2 times, most recently
from
7fab644
to
fd369f6
Compare
pdanpdan
force-pushed
the
color-datetime-kbd
branch
from
783482f
to
232299f
Compare
|
Does this add alphabetic selection to QSelect, like it works on native html select element? (like pressing 'K' on keyboard selects first option starting with 'K'). Lot of good stuff here anyway, thx ;) |
pdanpdan
force-pushed
the
color-datetime-kbd
branch
3 times, most recently
from
e672c30
to
cc13556
Compare
|
@panstromek No, I think the filter is good enough for the moment, but maybe later |
pdanpdan
force-pushed
the
color-datetime-kbd
branch
from
cc13556
to
c591e6c
Compare
|
This is a really important PR. Nice job @pdanpdan !!! @rstoenescu - any reason not to integrate it? |
pdanpdan
force-pushed
the
color-datetime-kbd
branch
4 times, most recently
from
f6ac37e
to
8c85759
Compare
pdanpdan
force-pushed
the
color-datetime-kbd
branch
4 times, most recently
from
b3cc2f3
to
ccaca4d
Compare
- QModal - fix not emmiting dismiss on ESC - focus after show - add back noRefocus - QPopover - focus after show - refocus after hide (noRefocus prop) - allow toggle by keyboard ENTER - QDialog - fix button focus - find button by class name (q-btn) - add back noRefocus - QFab - refocus after hide - QTab / QRouteTab - focus with keyboard - allow select with keyboard ENTER - QColor and QDatetime - fix tabindex lost on close - fix popup not closing on blur - QColorPicker - fix incorrect tabindex on disable - allow to select saturation on click on mobile (was working only on drag) - QDatetimePicker.mat - allow keyboard adjustment of all values - QActionsheet - select option with ENTER/SPACE, navigation with TAB - trigger selection on keyup to avoid click on original button - QAutocomplete - use QPopup with noFocus - QKnob, QSlider, QRange - keyboard updating (UP|RIGHT +, DOWN|LEFT -, CTRL+... 10*) - QSelect - remove autofocusFilter - always select filter if present - move keyboard navigation on QPopover - delay popover.reposition on filter to allow resize - v-back-to-top, v-close-overlay, v-go-back, v-ripple - trigger by keyboard ENTER - QInput - set model on ENTER
pdanpdan
force-pushed
the
color-datetime-kbd
branch
from
ccaca4d
to
b3378c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2121, close #1996, close #2113, close #2137, close #1038