Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider infinite scrolling #453

Merged
merged 4 commits into from
Mar 12, 2017

Conversation

stephentuso
Copy link
Contributor

I needed infinite scrolling so I modified this quickly, it should probably be cleaned up some. Opening this for some feedback.

This works by moving the first slide to the right of the last one when it is scrolled to the end, and the last to the left of the first when scrolled to the start (using the order css property). Empty divs were added before and after the slot to fill the space when the order is changed.

@rstoenescu
Copy link
Member

Works beautifully. Thanks for taking time for a PR. Will resolve merge conflicts and make some small adjustments and then push it. It will go into v0.13.5

@rstoenescu rstoenescu added this to the v0.13.5 milestone Mar 11, 2017
@rstoenescu
Copy link
Member

Thinking of also adding an "animation" prop so it will jump from one slide to another like a carousel.

@stephentuso
Copy link
Contributor Author

Thanks, sounds good. By animation do you mean automatically moving to the next slide? That would work nicely with the infinite scrolling, and I think "autoplay" is a common term for that

@rstoenescu
Copy link
Member

Yes, exactly. Meant autoplay. Works beautifully with your work. Thanks again! Will release this tomorrow.

@rstoenescu rstoenescu merged commit dc11e26 into quasarframework:dev Mar 12, 2017
@danikane
Copy link

Hey guys, thanks for this great addition! Is it possible to add this to Gallery Slider as well?

@rstoenescu
Copy link
Member

Damn, totally forgot about it. Wanted to do it for Gallery too. Will push a commit today or tomorrow. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants