Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Errformat to ReviewDog #33

Open
BinaryHexer opened this issue Mar 23, 2019 · 6 comments
Open

Add Errformat to ReviewDog #33

BinaryHexer opened this issue Mar 23, 2019 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@BinaryHexer
Copy link

BinaryHexer commented Mar 23, 2019

Currently it seems that Reviewdog doesn't support go-consistent.

Here is the error that Reviewdog spews out:

reviewdog: "goconsistent" is not supported. consider to add new errrorformat to https://github.com/haya14busa/errorformat

While it is possible to workaround this by defining a custom error format for Reviewdog, this is error-prone since whenever the output of the tool changes Reviewdog will fail to parse the output.
For the same reason I think any non-maintainer that tries to make a PR to Reviewdog for adding error format for go-consistent will run into the same concern.

I hope the maintainers of go-consistent will consider this!

@quasilyte
Copy link
Owner

I'll look into that, thanks. PRs are welcome, by the way.

@quasilyte quasilyte added the help wanted Extra attention is needed label Mar 23, 2019
@jlwt90
Copy link

jlwt90 commented Feb 16, 2020

@quasilyte I would like to have this feature too and created a pull request there.
Could you review the error format in this PR?

It doesn't accept error string (only error code) but I think it's good enough for now :)

@jlwt90
Copy link

jlwt90 commented Mar 3, 2020

@quasilyte Sorry, if possible, I would like to have your review for this PR:
reviewdog/errorformat#47
Thanks! :)

@quasilyte
Copy link
Owner

@jlwt90, sorry for the late response, I had hard times finding a free time.

Your PR (although already merged) looks good to me. Thank you.

@quasilyte
Copy link
Owner

I believe we can close this issue now.

@jlwt90
Copy link

jlwt90 commented Apr 11, 2020

@quasilyte No problem! Thank you for your review! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants