config: omit Authorization header for empty claims #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdonnay
requested review from
alecmerdler,
jzelinskie and
ldelossa
as code owners
|
@majewsky could you give this a try when you get a chance? |
|
@hdonnay Thanks for your quick response on this issue. Unfortunately, I will be on vacation next week, and I did not get to test-driving this PR today. I'll get back to you when I'm back from vacation. |
This change makes the HTTP client configuration method accept a Claims pointer, and if `nil` is passed, omits the automatic signing that would happen if a PSK was configured. Fixes quay#1283. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
added a commit
to hdonnay/clair
that referenced
this pull request
Jun 11, 2021
This change makes the HTTP client configuration method accept a Claims pointer, and if `nil` is passed, omits the automatic signing that would happen if a PSK was configured. Backports quay#1284. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
|
Feeling confident about this, so I'm going to merge and we can deal with any edge cases that pop-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the HTTP client configuration method accept a Claims
pointer, and if
nilis passed, omits the automatic signing that wouldhappen if a PSK was configured.
Fixes #1283.