-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove detectors #817
Remove detectors #817
Conversation
api/v3/clairpb/clair.proto
Outdated
// The list of layers along with detected features in each. | ||
repeated AncestryLayer layers = 3; | ||
} | ||
// The ancestry requested. | ||
Ancestry ancestry = 1; | ||
// The status of Clair at the time of the request. | ||
ClairStatus status = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need the status so that clients can determine when they need to rescan something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
LGTM if you squash the last two commits into one. |
fd19ddd
to
8320320
Compare
@jzelinskie squashed. |
e325209
to
d6364d1
Compare
d6364d1
to
11bb943
Compare
@jzelinskie should be good to go. Added .clang-format, make targets for proto linting and jsonnet compilation. CI passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 final change
Makefile
Outdated
|
||
.PHONY: gen-drone-config | ||
gen-drone-config: | ||
jsonnet -y .drone.jsonnet -o .drone.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this drone jsonnet --stream
since that's what their documentation says to use.
Closes milestone: #745
Removes detectors from AncestryGet rpc call. Response is now: