chore: Add georeplication variable check (PROJQUAY-4363) #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we didn't check for the presence of `QUAY_DISTRIBUTED_STORAGE_PREFERENCE` when `FEATURE_STORAGE_REPLICATION` was set to `true`. In certain situations, this would cause issues with what storage backend is being used during pushes. With this change, Quay will not allow execution unless preferred storage engine is explicitly defined.
Previously, we didn't check for the presence of `QUAY_DISTRIBUTED_STORAGE_PREFERENCE` when `FEATURE_STORAGE_REPLICATION` was set to `true`. In certain situations, this would cause issues with what storage backend is being used during pushes. With this change, Quay will not allow execution unless preferred storage engine is explicitly defined.
ibazulic
changed the title
bcaton85
reviewed
Aug 30, 2022
| @@ -318,6 +318,14 @@ def _request_end(resp): | |||
| else: | |||
| docker_v2_signing_key = JsonWebKey.generate_key("RSA", 2048, is_private=True) | |||
|
|
|||
| # Check if georeplication is turned on and whether env. variables exist: | |||
| if os.environ.get("QUAY_DISTRIBUTED_STORAGE_PREFERENCE") is None and app.config.get( | |||
There was a problem hiding this comment.
For my knowledge, why is one read from the config and the other from the environment variable? Is QUAY_DISTRIBUTED_STORAGE_PREFERENCE meant to be set somewhere else?
There was a problem hiding this comment.
@bcaton85 the FEATURE_STORAGE_REPLICATION only enables the storagereplication worker. The QUAY_DISTRIBUTED_STORAGE_PREFERENCE is set as an env. variable to override default value for the storage engine that is used in a specific DC. You'd always want to use a local storage solution in the DC where Quay is running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't check for the presence of
QUAY_DISTRIBUTED_STORAGE_PREFERENCEwhenFEATURE_STORAGE_REPLICATIONwas set totrue. In certain situations, this would cause issues with what storage backend is being used during pushes. With this change, Quay will not allow execution unless preferred storage engine is explicitly defined.