Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

healthcheck: Use db_kwargs in health check (PROJQUAY-4222) #1507

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

jonathankingfc
Copy link
Contributor

  • The database health check is currently not using the db_kwargs and not using ssl settings
  • This is causing health check failures for MySQL behind SSL

- The database health check is currently not using the db_kwargs and not using ssl settings
- This is causing health check failures for MySQL behind SSL
Copy link
Contributor

@HammerMeetNail HammerMeetNail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammerMeetNail HammerMeetNail removed the request for review from kleesc August 31, 2022 18:20
@HammerMeetNail HammerMeetNail merged commit c36945b into quay:master Aug 31, 2022
@HammerMeetNail
Copy link
Contributor

/cherry-pick redhat-3.7

@openshift-cherrypick-robot

@HammerMeetNail: new pull request created: #1511

In response to this:

/cherry-pick redhat-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants