Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding lint-staged to be used with husky for a Git pre-commit hook #120

Closed
nickytonline opened this issue Oct 29, 2020 · 3 comments · Fixed by #148
Closed

Consider adding lint-staged to be used with husky for a Git pre-commit hook #120

nickytonline opened this issue Oct 29, 2020 · 3 comments · Fixed by #148
Labels
infrastructure Anything infrastructure related released on @next released

Comments

@nickytonline
Copy link
Collaborator

nickytonline commented Oct 29, 2020

It's great that the project is already using the husky package for Git hooks. Currently there is a Git pre-push hook. Consider a pre-commit hook using lint-staged. Having a pre-commit hook can lint (potentially fix issues), run prettier and also be able to run tests related to the files being changed.

For an example of this in the wild, see https://github.com/forem/forem/blob/master/package.json#L30-L75

Documents and Links

@nickytonline nickytonline added the infrastructure Anything infrastructure related label Oct 29, 2020
@raae
Copy link
Member

raae commented Oct 29, 2020

Yeah, that would be great!

@raae-bot
Copy link

🎉 This issue has been resolved in version 0.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@raae-bot
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything infrastructure related released on @next released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants