Init scripts also on initialClientRender

[raae]

@adamwiggall made me aware we need to processInstagram and loadTwitter also on onInitalClientLoad.

I would combine processInstagram and loadTwitter in a initScripts function and call that both from both onInitalClientLoad and onRouteUpdate.

The code for this can be found in gatsby-browser.js.

[victornguyen]

In working on this, I've noticed that onRouteUpdate() gets called on the initial page load anyway?

I've PR'ed up the change anyway in case making use of onInitialClientRender() solves something else I'm not aware of. The option is yours 😄

[raae]

I created a contentful project using their starter to test something else. And there I found that onRouteUpdate() and onInitialClientRender() is called before the page templates render.

I think this kind of issue prompted this proposed solution. But it does not fix it as both are called prematurely. I cannot figure out why this is the case and what is causing it. A hack is to let onInitialClientRender() call initScript() after a timeout, but that is very hacky.

[raae]

Sorry, this only happened in dev mode, not when building and serving.

@adamwiggall can you remember what caused us to believe we had to also init scripts on onInitialClientRender().

[adamwiggall]

@raae I’m pretty sure when we visited a page using oembed with a clean cache embeds didn’t render. Refreshing the page made them render.