Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab should be draggable #7

Closed
invisal opened this issue Jun 15, 2023 · 0 comments · Fixed by #34
Closed

Tab should be draggable #7

invisal opened this issue Jun 15, 2023 · 0 comments · Fixed by #34
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@invisal
Copy link
Collaborator

invisal commented Jun 15, 2023

Currently, our tab does is not draggable to re-arrange its position. We can make it draggable like in Visual Studio Code as attached video.

WelcomeScreen.tsx.-.query-master.-.Visual.Studio.Code.2023-06-15.08-53-29.mp4

Where to implement it?

The tab component is located in this files.
https://github.com/invisal/query-master/blob/main/src/renderer/components/WindowTab/index.tsx

We can add drag functionality in this place. We can expose two more properties:

<WindowTab
   onTabChanged={setTab}
   draggable
 />
  • draggable means that it is possible to drag tab. There are some places where we want the tab to stay in fixed position.
  • onTabChanged will change the tab states when drag is success.
@invisal invisal added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant