-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow either DataValues or Missings for representing missing data #34
Comments
What is the use-case for this? https://github.com/davidanthoff/StatFiles.jl should support getting a |
I believe that as of version 0.7 of Julia, the |
Yes, that is so. Should we revisit once 0.7 is out (or at least a beta or something like that)? There are some really complicated integration questions on how all of this interacts with Query.jl that just will require more time. But I do hope that in the meantime the approach with StatFiles.jl should work for folks that want a |
I agree that waiting until 0.7 is at least in beta is a good idea. |
I don't think 0.7 will change a lot of things (except performance) here. You could as well use Missings.jl for now, it should provide the same features on 0.6. |
I have a version using Missing in the I haven't created a pull request yet. I wanted to check first with @davidanthoff to see if he would be open to this approach. This version works on Julia 0.6.2 and Julia 0.7.0-dev. Tests don't work because this returns |
@davidanthoff I wanted to run this by you before preparing a PR.
I think it should be possible to represent missing data values in the result using either the
DataValues
package or theMissings
package. Suppose that all theread_*
functions had an optionalBool
argument to control this choice with its value being stored in theReadStatDataFrame
. Thehandle_variable!
function then ends withI think the only additional changes would be to use
in the signature of the
readfield!
methods and to add the Missings package.Shall I prepare a PR for your consideration?
The text was updated successfully, but these errors were encountered: