Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode flatpak commands in GUI dialogs #134

Closed
SuperSandro2000 opened this issue Mar 6, 2024 · 2 comments
Closed

Don't hardcode flatpak commands in GUI dialogs #134

SuperSandro2000 opened this issue Mar 6, 2024 · 2 comments
Labels
enhancement New feature or request needs testing

Comments

@SuperSandro2000
Copy link
Contributor

I am currently packaging goldwarden for NixOS. One of the problems I have encountered is that the GUI hardcodes flatpak run which obviously can't work when running outside of flatpak. To make goldwarden easier to package, this should be done smarter, ideally goldwarden should just run goldwarden and the rest is up to the packaging

eg https://github.com/quexten/goldwarden/blob/main/gui/src/gui/browserbiometrics.py#L45 or https://github.com/quexten/goldwarden/blob/main/gui/src/gui/ssh.py#L44

@quexten
Copy link
Owner

quexten commented Mar 6, 2024

Very cool initiative!

I guess we can move these to some kind of resource files (maybe just a JSON file with help command strings is enough?).

@quexten quexten changed the title Don't hardcode flatpak in GUI Don't hardcode flatpak commands in GUI dialogs Mar 6, 2024
@quexten quexten added the enhancement New feature or request label Mar 6, 2024
@quexten quexten mentioned this issue Mar 12, 2024
@quexten
Copy link
Owner

quexten commented May 3, 2024

#193 Implemented this by moving the commands to a resource.json file that can be overridden by the packaging distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs testing
Projects
None yet
Development

No branches or pull requests

2 participants