Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in secureboot firmware ? #335

Closed
philclifford opened this issue Jan 31, 2022 · 2 comments
Closed

Typo in secureboot firmware ? #335

philclifford opened this issue Jan 31, 2022 · 2 comments

Comments

@philclifford
Copy link
Contributor

philclifford commented Jan 31, 2022

elif [ -e "/usr/share/edk2-ovmf/OVMF_CODE.fd" ]; then

spotted one not testing the "secure" firmware - possibly pedantic but corrected to test for
/usr/share/edk2-ovmf/OVMF_CODE.secboot.fd in #322 ( and #324 etc )

@philclifford
Copy link
Contributor Author

Closed with merge of #322

@philclifford
Copy link
Contributor Author

@flexiondotorg on the stream I think this confused you - sorry. You effectively merged the change in #322 , and I'm pretty confident that's fine because it was looking like an obvious "test the-one-thing exists - if so we use oops thats another thing the-one-thing" fix of a copy-pasta edit with a mid-edit distraction. If I'm right all good - if not and there's a bizarre scenario in play then you need to revert that one line (currently line 396 in quickemu) . There's now a new PR to remove a duplicate elif stanza which would not be identical if line 396 were changed back.... I think I've now properly confused the remains of my brain
Hopefully TL;DR nothing to see or do here ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant