Gcp pubsub source #3720
Merged
Gcp pubsub source #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
reviewed
Aug 7, 2023
AyWa
commented
Aug 10, 2023
There was a problem hiding this comment.
I tried to applied all your comment @guilload. Let me know if I misunderstood something.
In next PR, I will try to add the ACK of the message with some test.
Then I will try to add parallelism if needed, and some integration test.
AyWa
force-pushed
the
gcp-pubsub-source
branch
2 times, most recently
from
64d9e70
to
caf10de
Compare
guilload
reviewed
Aug 10, 2023
guilload
reviewed
Aug 10, 2023
* Initial pubsub implementation/test * Allow pubsub to have multiple pipelines
AyWa
force-pushed
the
gcp-pubsub-source
branch
from
ca83a7b
to
aa33d1e
Compare
guilload
approved these changes
Aug 11, 2023
guilload
force-pushed
the
gcp-pubsub-source
branch
from
7f77157
to
cf1965b
Compare
|
Merged! Awesome job @magnalite and @AyWa. It's really great to land large features from OSS contributors. @AyWa, as a next step, I would welcome a PR that adds some tests before adding more new functionalities to the source (parallelism, ack on truncate). |
|
@AyWa @magnalite Ping me on Discord if you want some swag :) |
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of the great work of @magnalite and following advice of @guilload
This PR, fix the compilation/formatting issues of the previous PR and put the code behind a flag
gcp-pubsubAlso renamed everywhere
pubsubbygcp-pubsuborGcpPubSubto reduce confusion with other pubsub system.How was this PR tested?
I didnt test it. It will be added in step 3
Next Item
step 2: focus on supporting at-least-once delivery semantics for now and improve the current implementation as you suggested
step 3: add unit and integration tests for this source
step 4: test at scale (I can help with that and do so on our GCP account)
step 5: opportunistically support exactly-once delivery semantics