support _source_excludes,_source_includes in ES API #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
reviewed
Feb 13, 2024
| _source_excludes: &Option<Vec<String>>, | ||
| _source_includes: &Option<Vec<String>>, | ||
| ) -> ElasticHit { | ||
| let mut fields: BTreeMap<String, serde_json::Value> = |
There was a problem hiding this comment.
I don't think this will work with a field like app.id where the JSON document is {"app": {"id": 123}}
There was a problem hiding this comment.
We could do it at the fetch_docs_in_split level, we won't have to traverse all the json doc by doing it on a NamedFieldDocument.
There was a problem hiding this comment.
NamedFieldDocument is not flattened, we would still need to traverse the doc
There was a problem hiding this comment.
updated to handle paths
PSeitz
force-pushed
the
source_excludes
branch
from
a780cd0
to
689b16f
Compare
fmassot
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4564