add support delete index in es API #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
delete_pattern
branch
from
e51e3ee
to
822c504
Compare
PSeitz
force-pushed
the
delete_pattern
branch
from
740079c
to
41fc263
Compare
quickwit/rest-api-tests/scenarii/es_compatibility/0024-delete_indices.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,43 @@ | |||
| --- | |||
There was a problem hiding this comment.
it's a bummer these tests don't pass with --engine elasticsearch. I think we lack index creation to make them pass seamlessly, but it should be possible to create in the index conditionally with
engines:
- quickwit
# quickwit api here
---
engines:
- elasticsearch
# es api hereand removing the api_root and _elastic prefix on other requests.
There was a problem hiding this comment.
I updated the tests to cover elastic search compatibility
Comment on lines
238
to
240
| // disallow index_id patterns containing * | ||
| for index_id_pattern in &index_id_patterns { | ||
| if index_id_pattern.contains('*') { |
There was a problem hiding this comment.
we may also want to reject _all if we don't support it
There was a problem hiding this comment.
updated to reject _all
PSeitz
force-pushed
the
delete_pattern
branch
2 times, most recently
from
e23d083
to
3dbfc2c
Compare
PSeitz
force-pushed
the
delete_pattern
branch
from
3dbfc2c
to
01042d6
Compare
trinity-1686a
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3841
How was this PR tested?
rest-api-test