Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize pacing_rate #58

Open
kixelated opened this issue Nov 9, 2021 · 2 comments
Open

Visualize pacing_rate #58

kixelated opened this issue Nov 9, 2021 · 2 comments

Comments

@kixelated
Copy link

I use the congestion tab quite often for investigating QoS issues. It works great for Reno/CUBIC, but it's less useful after implementing BBR. The congestion window still exists, but BBR primarily limits the send rate via a pacer.

It would be nice if we could visualize the optional pacing_rate in recovery:metrics_updated. This is measured in bits/sec so it wouldn't fit with the other graphs. It would also be nice to add a new field called bandwidth_estimate to that event, graphing it alongside the pacing_rate.

@rmarx
Copy link
Member

rmarx commented Nov 10, 2021

Hey @kixelated, that seems like a fair request :)

A few questions of mine:

  1. It's in bits/sec so indeed wouldn't fit directly with the current y-axes, but I assume you would still like it plotted on the "top" graph, along with cwnd/loss etc.? e.g., as a separate line with its own y-axis/scaling? Or would it make more sense to have a "third" graph, in between the two current ones for example?
  2. What would the units of the bandwidth_estimate field ideally be in your opinion?
  3. Could you maybe provide 1 or more example qlog files with "realistic" behaviour for those parameters? So I can make sure e.g., the auto-scaling of the y-axis works well for normal values. For this, feel free to add the bandwidth_estimate field to the event yourself, using the units from question 2 :)

Since I know the FB people have also been using qlog for BBR, maybe they have some input here as well, so I can do as much as possible in 1 go? @mjoras @lnicco?

@joergdeutschmann-i7
Copy link

Related #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants