fix: forward Button “ref” property

quid · Jun 5, 2019 · 00d30e9 · 00d30e9
1 parent 9980128
commit 00d30e9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/react-core/src/Button/index.js b/packages/react-core/src/Button/index.js
@@ -100,7 +100,7 @@ const Button = styled(
       }
 
       return (
-        <Tag {...specificProps} {...props}>
+        <Tag {...specificProps} {...props} ref={ref}>
           {React.Children.map(children, node =>
             ['string', 'number'].includes(typeof node) ? (
               <span>{node}</span>

diff --git a/packages/react-core/src/Button/index.test.js b/packages/react-core/src/Button/index.test.js
@@ -113,6 +113,12 @@ it('renders a Button with type=submit', () => {
   expect(wrapper.find('button').props().type).toBe('submit');
 });
 
+it('forwards ref properly', () => {
+  const ref = React.createRef();
+  mount(<Button ref={ref}>Foobar</Button>);
+  expect(ref.current).toBeDefined();
+});
+
 // it('renders properly with isGroupChild property', () => {
 //   const wrapper = mount(<Button isGroupChild />);
 //   expect(wrapper).toMatchSnapshot();