fix: missing dependencies and minor linting issues

quid · Aug 9, 2019 · 88c3730 · 88c3730
1 parent f5611e8
commit 88c3730
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -49,6 +49,8 @@
     "@emotion/styled": "^10.0.4",
     "@quid/stylis-plugin-focus-visible": "^1.0.0",
     "@quid/theme": "^1.0.0",
+    "@quid/react-core": "^3.0.0",
+    "@quid/react-forms": "^3.0.0",
     "builder-init": "^0.5.1",
     "customize-cra": "^0.2.7",
     "enzyme": "^3.8.0",
@@ -65,6 +67,7 @@
     "lerna-alias": "^3.0.2",
     "lint-staged": "^8.1.0",
     "prettier": "^1.15.3",
+    "prop-types": "^15.7.2",
     "react": "^16.7.0",
     "react-app-rewired": "^2.1.1",
     "react-dom": "^16.7.0",

diff --git a/packages/react-dropdown/src/utils.js b/packages/react-dropdown/src/utils.js
@@ -37,6 +37,7 @@ export function filterByCategoryId(
         ...item,
       };
     }
+    return false;
   });
 }
 

diff --git a/packages/react-layouts/src/Modal/index.test.js b/packages/react-layouts/src/Modal/index.test.js
@@ -218,7 +218,7 @@ describe('Modal', () => {
     // info: https://github.com/facebook/react/issues/11098
     // more info: https://github.com/facebook/react/issues/11083
     // $FlowFixMe
-    Error.prototype.suppressReactErrorLogging = true;
+    Error.prototype.suppressReactErrorLogging = true; // eslint-disable-line no-extend-native
     const Logo = function Welcome() {
       return <div>Logo</div>;
     };
@@ -232,7 +232,7 @@ describe('Modal', () => {
       ).toThrowErrorMatchingSnapshot();
     } finally {
       // $FlowFixMe
-      Error.prototype.suppressReactErrorLogging = false;
+      Error.prototype.suppressReactErrorLogging = false; // eslint-disable-line no-extend-native
     }
   });
 });
diff --git a/packages/react-popover/package.json b/packages/react-popover/package.json
@@ -27,12 +27,15 @@
     "react": "^16.8.0"
   },
   "dependencies": {
+    "@emotion/css": "^10.0.14",
+    "@emotion/is-prop-valid": "^0.8.2",
     "@emotion/styled": "^10.0.10",
     "@quid/merge-refs": "^3.0.0",
     "@quid/react-mouse-outside": "^3.0.0",
     "@quid/react-use-controlled-state": "^3.0.0",
     "@quid/theme": "^3.0.0",
     "color": "^3.1.0",
+    "popper.js": "^1.15.0",
     "react-popper": "^1.3.3",
     "use-debounce": "^2.1.0"
   }

diff --git a/packages/react-tooltip/package.json b/packages/react-tooltip/package.json
@@ -28,6 +28,8 @@
   },
   "dependencies": {
     "@emotion/styled": "^10.0.11",
-    "@quid/react-popover": "^3.0.0"
+    "@quid/react-popover": "^3.0.0",
+    "popper.js": "^1.15.0",
+    "react-popper": "^1.3.3"
   }
 }
diff --git a/packages/react-use-controlled-state/src/index.js b/packages/react-use-controlled-state/src/index.js
@@ -44,7 +44,7 @@ function useControlledState(defaultValue, controlledValue, controlValue) {
 
       setInternalState(value);
     },
-    [controlledValue, controlValue, defaultValue]
+    [controlledValue, controlValue]
   );
 
   const state = isControlled(controlledValue, defaultValue)