Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trigger change event on InputNumber step up/down #105

Merged
merged 1 commit into from
Sep 26, 2019
Merged

fix: trigger change event on InputNumber step up/down #105

merged 1 commit into from
Sep 26, 2019

Conversation

FezVrasta
Copy link
Contributor

PR checklist

  • I have followed the "Committing and publishing" guidelines;
  • I have added unit tests to cover my changes;
  • I updated the documentation and examples accordingly;

Changes description

Previously if you clicked on the InputNumber arrows, the change event wasn't triggered.

Affected packages

  • @quid/react-forms

@FezVrasta FezVrasta merged commit 48f52e9 into master Sep 26, 2019
@FezVrasta FezVrasta deleted the fix/input-number-caret-events branch September 26, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pechitook pechitook pechitook approved these changes

@gabrielmicko gabrielmicko Awaiting requested review from gabrielmicko

@gayatrisss gayatrisss Awaiting requested review from gayatrisss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FezVrasta @pechitook