fix: properly space Icon when inside Button #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FezVrasta
commented
Mar 21, 2019
FezVrasta
force-pushed
the
fix/button-icon-spacing
branch
from
8e2773f
to
d611af4
Compare
gabrielmicko
approved these changes
Apr 5, 2019
gabrielmicko
reviewed
Apr 5, 2019
FezVrasta
force-pushed
the
fix/button-icon-spacing
branch
2 times, most recently
from
8c428e3
to
b66814b
Compare
FezVrasta
force-pushed
the
fix/button-icon-spacing
branch
from
b66814b
to
b2bb849
Compare
FezVrasta
added a commit
that referenced
this pull request
Apr 18, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Changes description
This fixes an issue where an Icon component inside a Button component wasn't properly aligned if the Icon was on the right of the text.
Affected packages