-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to write display management metadata suited for tv-led DV. #303
Comments
This doesn't seem convenient to add. It would need to be totally different functions that write the payload. |
Might not be convenient, but your tool already has almost all the code that would be needed for this functionality, mostly just with different numbers of bits being written. To me, this feature seems very useful and your tool seems like the natural place to get this output from given it already has almost all the needed code in place and is integrated into other projects like kodi to rewrite bitstreams. |
Is there better documentation than the ETSI GS CCM 001 doc? I guess it's mostly the syntax tables but it just seems like old versions of the RPU spec. |
Not that I found. That doc does seem fairly old, and that table was missing some info with reserved bits. As what was there aligned with your existing work, I filled in the blanks and assumed what was missing followed the same pattern, i.e. promoting bit depths. The other info was inferred from examining captures of hdmi tunnels. Only writing the total number of metadata blocks was taken by looking at a capture of the hdmi tunnel when playing a cmv4.0 file. Only using 4 bits for I've then checked all of these minimal assumptions against data captured of the hdmi tunnel from a oppo and a AM6B+. I've then worked it the other way - taking some DV metadata, injecting it into the hdmi signal in this format, and observed the expected responses. Would you like the raw data I extracted from the hdmi tunnel captures to be provided? |
Sure, it can be useful. |
Will do. The format for this data can also be seen in the function |
The OneDrive links are not working for me. |
This byte sequence: |
Here is a copy. |
TV-led DV requires the display management metadata to be embedded into the top pixels as detailed in ETSI GS CCM 001. To do this requires access to the dm metadata in the format given by Table 3 in that doc.
Would like a function added to the c-api that writes nal units in this format. Very similar to the existing code for writing dm metadata. Only real differences are
affected_dm_metadata_id
written as 4 bits.current_dm_metadata_id
written as 4 bits.scene_refresh_flag
written as 8 bits.Sure you don't want to actually use my code, but I have a working hack-job of your code that output in the right format. Changes I made are here
The text was updated successfully, but these errors were encountered: