Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove react-scripts #84

Merged
merged 1 commit into from
Jun 22, 2023
Merged

remove react-scripts #84

merged 1 commit into from
Jun 22, 2023

Conversation

johnpmitsch
Copy link
Contributor

@johnpmitsch johnpmitsch commented Jun 22, 2023

Dependabot has an alert for nth-check, which is required by react-scripts

yarn list nth-check
yarn list v1.22.18
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─ nth-check@2.1.1
└─ react-scripts@5.0.1
   └─ nth-check@1.0.2

Unfortunately, react-scripts doesn't have a later production version (see open issue complaining about this)

I just removed it since it seems like we only use it in the ts declaration file that is included by default for create-react-app. There's an issue of people complaining about this too 😆 I don't think we need it for any of our usage and could workaround anything that we would need the types for, so I removed it for now

@johnpmitsch
Copy link
Contributor Author

johnpmitsch commented Jun 22, 2023

nth-check is still there, but it's upgraded to a sufficent version:

The earliest fixed version is 2.0.1.

yarn list nth-check
yarn list v1.22.18
warning Filtering by arguments is deprecated. Please use the pattern option instead.
└─ nth-check@2.1.1
✨  Done in 0.27s.
yarn why nth-check
yarn why v1.22.18
[1/4] 🤔  Why do we have the module "nth-check"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "nth-check@2.1.1"
info Reasons this module exists
   - "@svgr#webpack#@svgr#plugin-svgo#svgo#css-select" depends on it
   - Hoisted from "@svgr#webpack#@svgr#plugin-svgo#svgo#css-select#nth-check"
info Disk size without dependencies: "120KB"
info Disk size with unique dependencies: "132KB"
info Disk size with transitive dependencies: "132KB"
info Number of shared dependencies: 1
✨  Done in 0.27s.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 78f41e8 on nft_hooks_dependabot into ab54825 on main.

@johnpmitsch johnpmitsch merged commit f79a9ff into main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants