Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Gemfile to pin Ruby dependencies #1544

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add a Gemfile to pin Ruby dependencies #1544

merged 1 commit into from
Jun 27, 2017

Conversation

mdpye
Copy link
Contributor

@mdpye mdpye commented Jun 23, 2017

Otherwise breaking changes in e.g. Jekyll interface will render the development environment broken.

This was prompted by a breaking change introduced in Jekyll 3.5.0, as discussed in #1536.

With this Gemfile and lock, Bundler can be used to ensure that tested tool versions are used and to manage upgrades.

@jhchen
Copy link
Member

jhchen commented Jun 26, 2017

Can you have it depend on https://github.com/github/pages-gem instead? We don't get to choose which version of Jekyll to use -- Github does.

Otherwise breaking changes in e.g. jekyll interface will render the
development environment broken.
@mdpye
Copy link
Contributor Author

mdpye commented Jun 27, 2017

Amended to use github-pages.

The Gemfile could either be left as a guide and tool people people who need it, or, in order to produce a repeatable environment, the relevant npm scripts could be prepended with bundle exec to ensure that the exact versions specified are in fact being used.

@jhchen jhchen merged commit ae0a92e into slab:develop Jun 27, 2017
@jhchen
Copy link
Member

jhchen commented Jun 27, 2017

Thanks! Agree on the repeatable developer environment e5fbc3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants