Fix double indirect call in default CID generator factory

A lambda expression is a unique ZST, but coercing it to a function pointer discards that information.
quinn-rs · May 23, 2024 · 9229c37 · 9229c37
1 parent 70f5f6d
commit 9229c37
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/quinn-proto/src/config.rs b/quinn-proto/src/config.rs
@@ -630,8 +630,8 @@ pub struct EndpointConfig {
 impl EndpointConfig {
     /// Create a default config with a particular `reset_key`
     pub fn new(reset_key: Arc<dyn HmacKey>) -> Self {
-        let cid_factory: fn() -> Box<dyn ConnectionIdGenerator> =
-            || Box::<HashedConnectionIdGenerator>::default();
+        let cid_factory =
+            || -> Box<dyn ConnectionIdGenerator> { Box::<HashedConnectionIdGenerator>::default() };
         Self {
             reset_key,
             max_udp_payload_size: (1500u32 - 28).into(), // Ethernet MTU minus IP + UDP headers