Skip to content

Commit

Permalink
Update docs for UDP fragmentation configuration support
Browse files Browse the repository at this point in the history
As of 092a768, MTUD is enabled by
default on all major platforms, and automatically disabled regardless
of configuration otherwise.
  • Loading branch information
Ralith committed Jul 15, 2023
1 parent b7695b1 commit f4091ff
Showing 1 changed file with 1 addition and 20 deletions.
21 changes: 1 addition & 20 deletions quinn-proto/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,26 +193,7 @@ impl TransportConfig {

/// Specifies the MTU discovery config (see [`MtuDiscoveryConfig`] for details).
///
/// Defaults to `None`, which disables MTU discovery altogether.
///
/// # Important
///
/// MTU discovery depends on platform support for disabling UDP packet fragmentation, which is
/// not always available. If the platform allows fragmenting UDP packets, MTU discovery may end
/// up "discovering" an MTU that is not really supported by the network, causing packet loss
/// down the line.
///
/// The `quinn` crate provides the `Endpoint::server` and `Endpoint::client` constructors that
/// automatically disable UDP packet fragmentation on Linux and Windows. When using these
/// constructors, MTU discovery will reliably work, unless the code is compiled targeting an
/// unsupported platform (e.g. iOS). In the latter case, it is advisable to keep MTU discovery
/// disabled.
///
/// Users of `quinn-proto` and authors of custom `AsyncUdpSocket` implementations should ensure
/// to disable UDP packet fragmentation (this is strongly recommended by [RFC
/// 9000](https://www.rfc-editor.org/rfc/rfc9000.html#section-14-7), regardless of MTU
/// discovery). They can build on top of the `quinn-udp` crate, used by `quinn` itself, which
/// provides Linux, Windows, macOS, and FreeBSD support for disabling packet fragmentation.
/// Enabled by default.
pub fn mtu_discovery_config(&mut self, value: Option<MtuDiscoveryConfig>) -> &mut Self {
self.mtu_discovery_config = value;
self
Expand Down

0 comments on commit f4091ff

Please sign in to comment.