Allow compilation with --cfg fuzzing but not --features=arbitrary
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you try looking at this? I think I would usually prefer disentangling over this. |
djc
approved these changes
May 26, 2023
I did not, but if you hold off on merging, I will. |
smoelius
changed the title
--cfg fuzzing is passed but not --features=arbitrary--cfg fuzzing but not --features=arbitrary
|
@djc Is this better? |
|
Yes, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if
quinn-protois built without--features=arbitrary, one gets an error about an unresolved import. Thecompile_errorhelps to clarify why.An alternative would be to try and disentangle
--cfg fuzzingand--features=arbitrary. But this change is less invasive.