Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent an info message related to ack frequency. #1652

Merged
merged 2 commits into from
Aug 31, 2023
Merged

silent an info message related to ack frequency. #1652

merged 2 commits into from
Aug 31, 2023

Conversation

stormshield-damiend
Copy link
Contributor

Change an info into debug to silent a message that show too frequently.

djc
djc approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@djc djc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe "silent" -> "Silence" in the commit message?

Thanks!

Ralith
Ralith approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this definitely wasn't intended. We should probably even drop it further -- debug isn't intended to have a lot of routine noise.

quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
@Ralith Ralith enabled auto-merge (squash) August 31, 2023 17:29
@Ralith Ralith merged commit a516c2b into quinn-rs:main Aug 31, 2023
8 checks passed
@stormshield-damiend stormshield-damiend deleted the silent_info_ack_freq_rtt branch September 1, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stormshield-damiend @Ralith @djc