-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send path validation responses to the correct remote #1746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
Ralith
force-pushed
the
fix-path-validation
branch
2 times, most recently
from
January 23, 2024 03:09
7e5714b
to
57f0bad
Compare
djc
reviewed
Jan 23, 2024
Ralith
force-pushed
the
fix-path-validation
branch
3 times, most recently
from
January 24, 2024 01:25
c1ff4a6
to
3eeb984
Compare
Ralith
force-pushed
the
fix-path-validation
branch
from
January 24, 2024 01:26
3eeb984
to
0bae48d
Compare
djc
reviewed
Jan 24, 2024
Ralith
force-pushed
the
fix-path-validation
branch
2 times, most recently
from
January 24, 2024 22:29
8e5a09d
to
400f729
Compare
Ralith
force-pushed
the
fix-path-validation
branch
from
January 24, 2024 22:32
400f729
to
2a636c1
Compare
djc
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously always sent these on the active path, which undermines a peer's validation of the return direction of a candidate new path.