Introduce RecvStream::received_reset #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 19, 2024
MOZGIII
reviewed
May 19, 2024
djc
reviewed
May 21, 2024
Improves symmetry with `WriteError::Stopped`. The proto layer can't provide this behavior because it discards stream state, but we have our own application-owned state and need to defer error reporting sometimes anyway, so we might as well make this more intuitive.
|
Forgot to actually queue a |
djc
approved these changes
May 22, 2024
Ralith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870. I'm pretty sure I handled the state cleanup and flow control implications properly, but close review desired there all the same.