fix: remove debug assert that requires ordered acks for non mtu probe acks #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthebst
changed the title
djc
reviewed
Jun 6, 2024
| @@ -26,6 +26,12 @@ async fn run_server(addr: SocketAddr) { | |||
| // accept a single connection | |||
| let incoming_conn = endpoint.accept().await.unwrap(); | |||
| let conn = incoming_conn.await.unwrap(); | |||
|
|
|||
| loop { | |||
There was a problem hiding this comment.
Yep. Sorry. Pushed my test changes by accident.
|
This assert exists because the following code relies on that assumption for correctness. We need to study how this is occurring and adjust ACK processing and/or MTU detection logic accordingly. |
|
I would be willing to help debug this if you need help lmk. |
|
Any help would be appreciated, maybe you can have a read through the code and see if you can come up with a change proposal? Also a regression test that catches this would be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-probe acks can be out of order. As of my understanding the ordering is only given for probe acks.
To confirm: Should it also be removed for probe acks?
fixes #1889