From c9aaf3de926eaf6270608b03441ca1f6deb7e107 Mon Sep 17 00:00:00 2001 From: ChongChong He Date: Sat, 5 Oct 2024 01:00:32 +1000 Subject: [PATCH] remove unused code and comments --- .../test_radiation_marshak_dust_and_PE.cpp | 9 ++++++++- src/radiation/radiation_dust_system.hpp | 9 --------- src/radiation/source_terms_multi_group.hpp | 3 --- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/src/problems/RadMarshakDustPE/test_radiation_marshak_dust_and_PE.cpp b/src/problems/RadMarshakDustPE/test_radiation_marshak_dust_and_PE.cpp index 50b377eb1..3a808906b 100644 --- a/src/problems/RadMarshakDustPE/test_radiation_marshak_dust_and_PE.cpp +++ b/src/problems/RadMarshakDustPE/test_radiation_marshak_dust_and_PE.cpp @@ -74,9 +74,16 @@ template <> struct ISM_Traits { }; template <> -AMREX_GPU_HOST_DEVICE auto RadSystem::DefinePhotoelectricHeatingE1Derivative(amrex::Real const /*temperature*/, amrex::Real const num_density) +AMREX_GPU_HOST_DEVICE auto RadSystem::DefinePhotoelectricHeatingE1Derivative(amrex::Real const /*temperature*/, amrex::Real const /*num_density*/) -> amrex::Real { + // Values in cgs units from Bate & Keto (2015), Eq. 26. + // const double epsilon = 0.05; // default efficiency factor for cold molecular clouds + // const double ref_J_ISR = 5.29e-14; // reference value for the ISR in erg cm^3 + // const double coeff = 1.33e-24; + // return coeff * epsilon * num_density / ref_J_ISR; // s^-1 + + // constant rate for testing return PE_rate; } diff --git a/src/radiation/radiation_dust_system.hpp b/src/radiation/radiation_dust_system.hpp index e8c8ea2be..6d264fa82 100644 --- a/src/radiation/radiation_dust_system.hpp +++ b/src/radiation/radiation_dust_system.hpp @@ -10,10 +10,6 @@ template AMREX_GPU_HOST_DEVICE auto RadSystem::DefinePhotoelectricHeatingE1Derivative(amrex::Real const /*temperature*/, amrex::Real const num_density) -> amrex::Real { - // const double epsilon = 0.05; // default efficiency factor for cold molecular clouds - // const double ref_J_ISR = 5.29e-14; // reference value for the ISR in erg cm^3 - // const double coeff = 1.33e-24; - // return coeff * epsilon * num_density / ref_J_ISR; // s^-1 return 0.0; } @@ -45,9 +41,6 @@ AMREX_GPU_DEVICE auto RadSystem::ComputeJacobianForGasAndDust( } } - // const auto d_fourpiboverc_d_t = ComputeThermalRadiationTempDerivativeMultiGroup(T_d, radBoundaries_g_copy); - AMREX_ASSERT(!d_fourpiboverc_d_t.hasnan()); - // compute Jacobian elements // I assume (kappaPVec / kappaEVec) is constant here. This is usually a reasonable assumption. Note that this assumption // only affects the convergence rate of the Newton-Raphson iteration and does not affect the converged solution at all. @@ -57,7 +50,6 @@ AMREX_GPU_DEVICE auto RadSystem::ComputeJacobianForGasAndDust( result.J00 = 1.0; result.J0g.fillin(cscale); const double d_Td_d_T = 3. / 2. - T_d / (2. * T_gas); - // const double coeff_n = dt * dustGasCoeff_local * num_den * num_den / cscale; dEg_dT *= d_Td_d_T; const double dTd_dRg = -1.0 / (coeff_n * std::sqrt(T_gas)); const auto rg = kappaPoverE * d_fourpiboverc_d_t * dTd_dRg; @@ -167,7 +159,6 @@ AMREX_GPU_DEVICE auto RadSystem::ComputeJacobianForGasAndDustWithPE( result.J0g[nGroups_ - 1] -= PE_heating_energy_derivative * d_Eg_d_Rg[nGroups_ - 1]; } const double d_Td_d_T = 3. / 2. - T_d / (2. * T_gas); - // const double coeff_n = dt * dustGasCoeff_local * num_den * num_den / cscale; const auto dEg_dT = kappaPoverE * d_fourpiboverc_d_t * d_Td_d_T; const double dTd_dRg = -1.0 / (coeff_n * std::sqrt(T_gas)); const auto rg = kappaPoverE * d_fourpiboverc_d_t * dTd_dRg; diff --git a/src/radiation/source_terms_multi_group.hpp b/src/radiation/source_terms_multi_group.hpp index 910d93c70..f8069442e 100644 --- a/src/radiation/source_terms_multi_group.hpp +++ b/src/radiation/source_terms_multi_group.hpp @@ -123,9 +123,6 @@ AMREX_GPU_DEVICE auto RadSystem::ComputeJacobianForGas(double /*T_d*/ } } - // const auto d_fourpiboverc_d_t = ComputeThermalRadiationTempDerivativeMultiGroup(T_d, radBoundaries_g_copy); - AMREX_ASSERT(!d_fourpiboverc_d_t.hasnan()); - // compute Jacobian elements // I assume (kappaPVec / kappaEVec) is constant here. This is usually a reasonable assumption. Note that this assumption // only affects the convergence rate of the Newton-Raphson iteration and does not affect the converged solution at all.