Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alazar fixes and usability improvements #571

Merged
merged 11 commits into from
Apr 29, 2021
Merged

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Apr 21, 2021

Changes for alazar daq:

  • Do not touch the default config when arming a measurement
  • Keep current config in a seperate field
  • Extend record to a multiple of a configurable value (4KB by default)

@coveralls
Copy link

coveralls commented Apr 29, 2021

Pull Request Test Coverage Report for Build 2316

  • 23 of 32 (71.88%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 79.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/dacs/alazar.py 23 32 71.88%
Files with Coverage Reduction New Missed Lines %
qupulse/pulses/arithmetic_pulse_template.py 16 89.14%
Totals Coverage Status
Change from base Build 2301: -0.1%
Covered Lines: 7185
Relevant Lines: 8797

💛 - Coveralls

@terrorfisch terrorfisch merged commit 130538c into master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants