Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify and improve AtomicMultiChannelPT duration behaviour #593

Closed
2 tasks done
terrorfisch opened this issue May 18, 2021 · 1 comment
Closed
2 tasks done

Specify and improve AtomicMultiChannelPT duration behaviour #593

terrorfisch opened this issue May 18, 2021 · 1 comment
Milestone

Comments

@terrorfisch
Copy link
Member

terrorfisch commented May 18, 2021

Currently the keyword argument duration may be an expression, a boolean or None.

I would like to prepare the changes drafted in #535 which unfortunatly require the more complex changes from #552 by deprecating the boolean argument and only failing in __init__ if we can prove that the durations are incompatible.

Another option would be to be more permissive and only warn in that case that create_program will fail.

Current plan:

  • Deprecate boolean duration and treat it as None
  • Remove all duration checks in __init__ for now.
@terrorfisch
Copy link
Member Author

Implemented in #603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant