Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frozendict package #639

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Use frozendict package #639

merged 4 commits into from
Feb 11, 2022

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Feb 11, 2022

Use frozendict package which includes a C extension instead of self-written python code. The frozendict creation is roughly 5 times faster on my machine.

We keep the hand rolled code around until the next release so we do not break code.

TODO:

  • DeprecationWarning if frozendict is not installed
  • Measure performance influence
  • Add newspiece

Performance influence:

  • on my machine 3% improvement of
 ppt = PointPT([(0, 'i'), (1, 'i')], ('a',))
 fpt = ForLoopPT(ppt, 'i', 'n')
 fpt.create_program(parameters=dict(n=10000))```

@terrorfisch terrorfisch merged commit aa84488 into master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant