Skip to content

Bump octocrab from 0.42.0 to 0.42.1 (#477) #1442

Bump octocrab from 0.42.0 to 0.42.1 (#477)

Bump octocrab from 0.42.0 to 0.42.1 (#477) #1442

Triggered via push November 25, 2024 12:28
Status Success
Total duration 2m 33s
Artifacts

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
manual implementation of `Option::map`: src/importers/icalendar.rs#L224
warning: manual implementation of `Option::map` --> src/importers/icalendar.rs:224:12 | 224 | } else if let Some(attendee) = event | ____________^ 225 | | .multi_properties() 226 | | .get("ATTENDEE") 227 | | .and_then(|attendees| attendees.first()) ... | 231 | | None 232 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default help: try | 224 ~ } else { event 225 + .multi_properties() 226 + .get("ATTENDEE") 227 ~ .and_then(|attendees| attendees.first()).map(|attendee| attendee.value().to_owned()) }; |
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`: src/importers/icalendar/cdss.rs#L177
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/importers/icalendar/cdss.rs:177:5 | 177 | / match (event.city.as_str(), event.state.as_deref()) { 178 | | ("Henrico", Some("VA")) => { 179 | | event.city = "Richmond".to_string(); 180 | | } 181 | | _ => {} 182 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 177 ~ if let ("Henrico", Some("VA")) = (event.city.as_str(), event.state.as_deref()) { 178 + event.city = "Richmond".to_string(); 179 + } |
accessing first element with `location_parts.get(0)`: src/importers/icalendar/cdss.rs#L112
warning: accessing first element with `location_parts.get(0)` --> src/importers/icalendar/cdss.rs:112:17 | 112 | location_parts.get(0).cloned().unwrap_or_default(), | ^^^^^^^^^^^^^^^^^^^^^ help: try: `location_parts.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default
you seem to be trying to use `match` for an equality check. Consider using `if`: src/importers/icalendar/balfolknl.rs#L143
warning: you seem to be trying to use `match` for an equality check. Consider using `if` --> src/importers/icalendar/balfolknl.rs:143:9 | 143 | / match event.city.as_str() { 144 | | "Lent" => event.city = "Nijmegen".to_string(), 145 | | _ => {} 146 | | } | |_________^ help: try: `if event.city.as_str() == "Lent" { event.city = "Nijmegen".to_string() }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: src/importers/icalendar/balfolknl.rs#L141
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/importers/icalendar/balfolknl.rs:141:35 | 141 | event.name = shorten_name(&raw_name); | ^^^^^^^^^ help: change this to: `raw_name` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/