-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload of artifacts fails when working-directory is set for check-r-package #614
Comments
Can you use |
I tried that now. Did not solve the problem. It was running the checks in the |
* Should fix r-lib#614, at least for the typical case where `check-dir` is a relative path. * `check-dir` is now resolved relative to the working directory, as absolute path to also make it independent of the working directory of subsequent steps were the resolved `check-dir-path` output is used.
@gaborcsardi , @AskPascal, I looked at this as a follow-up on similar aspects I contributed to earlier this month/year (#560, #595), see commits above replicating the issue (even in conjunction with a custom |
Fixed by #615. |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue |
Describe the bug
We are using the
check-r-package
action in a workflow to check a package in a sub-directory of the repository with the help of theworking-directory
input. A failed check will not generate artifacts but instead leads to the warning "No files were found with the provided path: check. No artifacts will be uploaded." The same behaviour is seen both when the inputcheck-dir
is set and when it is not specified.To Reproduce
Run log:
https://github.com/Olink-Proteomics/OlinkRPackage/actions/runs/2972694134
Expected behavior
If the
working-directory
input is set it should be propagated to the artifact step.Additional context
I suspect that adding
working-directory
here:actions/check-r-package/action.yaml
Line 38 in cc43801
The text was updated successfully, but these errors were encountered: