-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-coverage
action is not up to date with codecov authentification policy and should already include CODECOV_TOKEN
#822
Comments
Thanks for the investigation! Would you like to submit a PR to the example workflow? |
For the tweak in the yaml no prob. |
No, you only need to update the example workflow file in this repository. |
For the record, this should work automatically, without a token. But Codedov is rate limited in their GitHub API usage, so it is best to create a token. Some details: https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954 |
This is now fixed with the new |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue |
Hi guys ! Thanks for the package. Just discovered this yesterday.
Describe the bug
test-coverage
action is not up to date with codecov default authentication procedure.For coverage results to be uploaded to codecov.io by
covr::codecov()
a code cov token needs to be available in the environment.For example as a CODECOV_TOKEN secret.
To Reproduce
On a package repo :
Then push or make a PR to
main
ormaster
The test coverage job will succeed but your coverage badge will remain gray with an "Unknown" mention.
See this workflow
in order for the code coverage to be uploaded to codecov.
You need to click on the badge. You are then provided with a token.
This token should be included in a repository secret and defined in the env statement of the workflow as such:
See this commit
Once that done,
The coverage result was properly uploaded to codecov.io
See the corresponding workflow
Expected behavior
The env statement of the action
test-coverage
should already contained the following linesand users should be notified on why and how to set this CODECOV_TOKEN as a repository secret.
Additional context
covr::codecov()
should not failed silently. I will also open an issue in {covr}.In my different trials I came to realize that the GITHUB_PAT defined in the workflow was not of any use.
The workflow runs successfully without it.
See this (commit)[https://github.com/ALanguillaume/test.cd.pkgdown.gh/commit/6ff28e63f8c5e35a67e96e1d7f44927bb5ceb178] and workflow
The text was updated successfully, but these errors were encountered: