Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pkgdown for published releases and on workflow_dispatch #451

Merged
merged 4 commits into from
Dec 8, 2021

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Dec 6, 2021

Closes #450

@jennybc
Copy link
Member Author

jennybc commented Dec 6, 2021

If we pursue this, I can figure out if / how to update the section of examples/README.md.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #451 (6d7dff1) into master (61009b5) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d7dff1 differs from pull request most recent head abac6a3. Consider uploading reports for the commit abac6a3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61009b5...abac6a3. Read the comment docs.

@gaborcsardi
Copy link
Member

If we pursue this, I can figure out if / how to update the section of examples/README.md.

Didn't you already update that in this PR?

@jennybc
Copy link
Member Author

jennybc commented Dec 6, 2021

The auto-inclusion of the yaml happened, but I think the prose should change too, i.e. the bit that only a human can do.

@jennybc
Copy link
Member Author

jennybc commented Dec 7, 2021

I added a sentence to README.

@gaborcsardi
Copy link
Member

Thanks! I am not sure why we build examples/README.md in an action. I guess it keeps the README consistent with the YAML, but we could still just build it locally whenever we change an example.

Anyway, I am merging this, and adding it to v1.

@gaborcsardi gaborcsardi merged commit ee45686 into master Dec 8, 2021
@gaborcsardi gaborcsardi deleted the update-event-triggers-for-pkgdown branch December 8, 2021 10:37
@jennybc
Copy link
Member Author

jennybc commented Dec 8, 2021

I am not sure why we build examples/README.md in an action. I guess it keeps the README consistent with the YAML, ..

Yeah what you say and perhaps a bit of dog-fooding.

@jennybc
Copy link
Member Author

jennybc commented Dec 9, 2021

I wasn't really worried, but I've just successfully exercised the releases.published change via the usethis release of v2.1.5:

https://github.com/r-lib/usethis/actions/workflows/pkgdown.yaml

@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only build pkgdown on version tags
4 participants