handle tinytex 2023 change about windows directory #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@gaborcsardi What is your release process for updating Possible to update the |
cderv
added a commit
to yihui/knitr
that referenced
this pull request
Mar 31, 2023
so we need to use dev branch unfortunately
|
Ditto for #716! The fix is in but the builds are still failing. Will be nice to bump the |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
clrpackages
pushed a commit
to clearlinux-pkgs/R-knitr
that referenced
this pull request
Jun 9, 2023
Christophe Dervieux (10):
Update GHA workflow to fix recent failure (#2236)
Improve error report when chunk fails (#2218)
check if options is missing or not
Add scss engine in comment chars
handles empty string for package name in write_bib()
Update NEWS and bump dev version
Small tweaks for spring cleaning (#2245)
Fix r-lib/actions#712 no yet in `@v2`
No specific processing when inside quarto (#2248)
fix #1842: coerce the keys into character for caching (#2249)
Daniel Possenriede (1):
reverse opts, code order for psql and mysql engines (#2253)
Doug Hemken (1):
Stata engine - more specific cleanup of files (#2210)
Jon Harmon (1):
use option or environment variable for the imgur key in imgur_upload() (#2235)
Michael Chirico (1):
typo: e.g --> e.g. (#2217)
Sergio Oller (1):
fix #2232: trace chunk location via line numbers in progress bar (#2250)
Yihui Xie (25):
kapsner/autonewsmd#6 has been merged
fix #2213: no longer sanitize dots in figure file paths, and provide an option to turn off sanitization
make is_html_output() work when the pandoc output format is empty
also write out css/js for the markdown output format
no need to specify type="text/javascript" for `<script>`
out_format() could be empty, too (when running outside knit())
add \n directly to the beginning of the message, don't print label if it's empty, and don't print filename if it's not a file (e.g., when using `knit(text = ...)`)
[cosmetic] move the `error` handler to the back
close #2231: output formats `sweave` and `listings` should be treated as LaTeX output
use xfun::env_option() in xfun 0.39
use curl directly instead of the httr wrapper to upload the image to imgur.com
fix #2246: pdfcrop in TeX Live >= 2023 on Windows does not require the external ghostscript; for TeX Live < 2023, users have to set the environment variable TEXLIVE_WINDOWS_EXTERNAL_GS and point it to external ghostscript (also close rstudio/tinytex#391)
fix #2247: process child documents *after* option hooks have been executed (#2251)
fix #2257: fragment.only = TRUE -> template = FALSE
make sure the methods are functions
factor out cat(..., file = con)
close #2221: simplify progress output when the output connection does not support \r
suggest rstudioapi for 47bce017a506ee43e4b325547804ee7438910a59
fix #2238: before getting device arguments by device name in `dev.args`, make sure the device name exists in the `dev.args` list; if it doesn't exist there, treat `dev.args` as the list of arguments to be passed to `dev`
if all names of `dev.args` are graphical device names, treat it as list(dev = args) instead of list(args)
fix #2255: make it possible to substitute newlines in kable() with other strings, e.g., spaces or empty strings
amend b3936cafd9e5784e54c1cedcc842ab25c5b6dc2e: add `jira` to the doc
a hack to avoid breaking the current version of learnr on CRAN
use bibentry() instead of the old-style citEntry()
CRAN release v1.43
dmurdoch (2):
Fix conflict between collapse=TRUE and htmlwidgets (#2212)
support aria-labelledby in htmlwidgets (#2243)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR following new TeX Live 2023 release that modified the windows directory from
win32towindowsThis follows work in rstudio/tinytex-releases#36 to adapt our scripts, our bundles and Quarto. Updating the action is the last thing I believe.
I tested this worflow in https://github.com/cderv/test-actions/actions/runs/4492118666/jobs/7901556408 - Everything installed correctly and is added to PATH by
core.addPath()I ran
npm run buildlocally which produce the js file. If there is anything else to do, please tell me.