Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to include the '.Call calls' block in the generated cpp11.cpp #170

Closed
jimhester opened this issue May 7, 2021 · 1 comment
Closed
Labels
feature a feature request or enhancement

Comments

@jimhester
Copy link
Member

e.g. https://github.com/tidyverse/readr/blob/755c6c8681f09c772460c1a30b38bbfa3c7577f4/src/cpp11.cpp#L201-L226 are all redundant, because we already are defining the functions above them.

Including them generates a number of readability-redundant-declaration and readability-named-parameter lints from clang-tidy, so we should probably just remove the block entirely.

OTOH I think we will still need these if a package is using a mix of cpp11 and Rcpp, or some by hand .Call and cpp11, we will need to investigate that.

@jimhester jimhester added the feature a feature request or enhancement label Jun 7, 2021
@jimhester
Copy link
Member Author

Closed by #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant