Fix: downlit_html_*() keeps all pre classes
#155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebacher
changed the title
downlit_html() keeps all pre classesdownlit_html_*() keeps all pre classes
|
Actually, this PR doesn't work because it applies all html <- xml2::read_xml("
<div>
<div class='sourceCode'>
<pre class='sourceCode r my-class'>
<code class='sourceCode r'>
<span>Hello</span>
</code>
</pre>
</div>
<div class='sourceCode'>
<pre class='sourceCode r another-class'>
<code class='sourceCode r'>
<span>Hello</span>
</code>
</pre>
</div>
</div>"
)
downlit::downlit_html_node(html)
html
#> {xml_document}
#> <div>
#> [1] <div class="sourceCode">\n <pre class="downlit sourceCode r my-class dow ...
#> [2] <div class="sourceCode">\n <pre class="downlit sourceCode r my-class dow ...Created on 2022-08-08 by the reprex package (v2.0.1) Therefore, I close it and will make a new one if I find a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #149, close #156.
downlit_html()now keeps allpreclasses, which allows for customization of code blocks inpkgdownusing chunk optionsclass.sourceandattr.source.Old behavior (
.my-classis not kept):Created on 2022-08-05 by the reprex package (v2.0.1)
New behavior (
.my-classis kept):Created on 2022-08-05 by the reprex package (v2.0.1)
@cderv You said that a fix for this should also fix #133 but I didn't look at #133 because of time and because it is related to several other issues.
Happy to modify the code and to bump version and NEWS if required.