Do not prepend oauth_ to additional parameters for oauth_signature #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhester
force-pushed
the
bugfix/oauth_signature
branch
2 times, most recently
from
ca6def7
to
0b39c49
Compare
The flickr API for instance needs all query parameters to be included in the signature
jimhester
force-pushed
the
bugfix/oauth_signature
branch
from
0b39c49
to
5e49c92
Compare
| @@ -31,11 +31,11 @@ init_oauth1.0 <- function(endpoint, app, permission = NULL, | |||
| authorize_url <- modify_url(endpoint$authorize, query = list( | |||
| oauth_token = token, | |||
| permission = "read")) | |||
| verifier <- oauth_listener(authorize_url, is_interactive)[[1]] | |||
| verifier <- oauth_listener(authorize_url, is_interactive)$oauth_verifier | |||
There was a problem hiding this comment.
I think the use of position was deliberate here
There was a problem hiding this comment.
Yeah it was changed with 7261a52#commitcomment-17702567, unfortunatly subsetting by position breaks when authenticating with flickr at least. I don't know if they are not returning the proper response or if it needs to be reverted.
There was a problem hiding this comment.
Ok I have updated it as suggested with da2bef0
Some APIs simply return the first item as the verifier token, others return a named oauth_verifier (which may not be first) along with other information.
jimhester
force-pushed
the
bugfix/oauth_signature
branch
from
24ef81a
to
da2bef0
Compare
|
Ok this was modified as discussed to check for oauth_verifier in the returned JSON and otherwise take the first item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flickr API for instance needs all query parameters to be included in
the signature. (https://www.flickr.com/services/api/auth.oauth.html#yui_3_11_0_1_1464787470505_317)
With this change I am able to get a 200 response with the following code (app secret redacted)