OAuth 1.0 normalized URL must exclude default port #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind also adding a test? I think the easiest way would be to split |
|
@leeper are you interested in finishing this off? |
|
Sorry, I wanted to get to it but haven't had time. Maybe this weekend? |
|
I'd like to release by Friday, but I can finish it off. |
|
Ok, thanks. Sorry for not getting to it. |
|
No problems. Refactoring was a bit more involved than I'd expected so probably better for me to do anything. Thanks for bringing this to my attention and for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
oauth_signature()related to port handling. The OAuth 1.0 spec indicates:In other words, if port is specified as 80 for HTTP or 443 or HTTPS, the port number needs to be excluded from the normalized URL that is used in the OAuth 1.0 signature.
oauth_signature()currently always includes the port number even if it is the default port number.This PR fixes that.