-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with newest glibc #25
Comments
@Enchufa2 Thanks for letting us know. @hadley @jimhester Can somebody from the tidyverse team take this on? As a reminder, we vendored the testthat code here to remove the indirect dependency of ggplot2 on testthat. |
Looks like it's just a matter of updating the catch code to the latest release. |
@jimhester I saw your comment in the testthat repo about Catch1 vs Catch2. Would it make sense here to switch to Catch2? isoband already requires C++11. |
No, I think I would probably just use the same fix here as in r-lib/testthat#1403 |
Sounds good to me, thanks! |
@Enchufa2 Could you try with the latest development version? This should be fixed now. If it looks good on your end I'll release a patch version soon. |
LGTM! |
The isoband@0.2.4/glibc incompatibility is outside this repo's control but solved by upgrading isoband to 0.2.5 (newer isoband versions are available, but this was enough to fix our problem). + r-lib/isoband#25 + specified supported R version fully (v4.0.3)
Same issue as r-lib/testthat#1373, because you include the source of testthat in this package:
SIGSTKSZ
is not a constant anymore. You can check e.g. in Fedora rawhide.The text was updated successfully, but these errors were encountered: