Use IOCP on Windows #106
Merged
Use IOCP on Windows #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently fails, because WaitForMultipleObjects can wait on at most 64 objects. It will work, once we switch to IOCP.
This allows polling more than 64 connections, and also simplifies the workflow somewhat.
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
+ Coverage 74.09% 74.38% +0.28%
==========================================
Files 28 29 +1
Lines 2471 2495 +24
==========================================
+ Hits 1831 1856 +25
+ Misses 640 639 -1
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
WaitForMultipleObjects.This allows polling more than 64 connections at once. It also simplifies the workflow a bit.
The polling part is not very clean, because it turns out that the connection -> pollable conversion is not a very good model. In particular, on Windows, it is hard to find the connection that responses, after a poll. The libuv model (i.e. their "inheritance" between struct types) is a better fit.