Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option or envvar to skip LANG='C' check? #1563

Closed
heavywatal opened this issue Feb 4, 2022 · 5 comments · Fixed by #1689
Closed

option or envvar to skip LANG='C' check? #1563

heavywatal opened this issue Feb 4, 2022 · 5 comments · Fixed by #1689

Comments

@heavywatal
Copy link
Contributor

I have LANG='C' in my .Renviron to disable locales, and testthat::expect_true() suddenly started blaming it. How can I solve this warning?

Warning (test-write.R:5:3): save_as() works
Changing language has no effect when envvar LANG='C'
Backtrace:
 1. testthat::expect_true(file.exists(path))
      at test-write.R:5:2
 2. testthat:::expect_waldo_constant(act, TRUE, info = info)
 3. testthat:::waldo_compare(...)
 4. reporter$local_user_output()
 5. testthat::local_reproducible_output(...)
 6. withr::local_language(lang, .local_envir = .env)
@lionel- lionel- transferred this issue from r-lib/withr Feb 4, 2022
@heavywatal
Copy link
Contributor Author

Closing this because the issue seems to have been solved (in testthat, withr, waldo, or else?)

@heavywatal
Copy link
Contributor Author

It has not been solved yet.

@heavywatal heavywatal reopened this Jun 22, 2022
@heavywatal
Copy link
Contributor Author

#1566 may be a duplicate

@hadley
Copy link
Member

hadley commented Sep 19, 2022

Duplicate of #1566

@hadley hadley marked this as a duplicate of #1566 Sep 19, 2022
@hadley hadley closed this as completed Sep 19, 2022
@heavywatal
Copy link
Contributor Author

#1662 solved #1566, but current main still emits warnings with envvar LANG='C'.

heavywatal added a commit to heavywatal/testthat that referenced this issue Sep 21, 2022
@heavywatal
Skip local_language() when LANG='C' is set
48e22d6 
Fixes r-lib#1563.
This is a minor addition to r-lib#1662.
@heavywatal heavywatal mentioned this issue Sep 21, 2022
Merged
hadley pushed a commit that referenced this issue Sep 22, 2022
@heavywatal
Skip local_language() when LANG='C' is set (#1689)
0630319 
Fixes #1563. This is a minor addition to #1662.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip local_language() when LANG='C' is set heavywatal/testthat
2 participants
@hadley @heavywatal