Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make context and test part of "expectation" class #386

Closed
krlmlr opened this issue Mar 1, 2016 · 2 comments
Closed

Make context and test part of "expectation" class #386

krlmlr opened this issue Mar 1, 2016 · 2 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Mar 1, 2016

so that add_result = function(result) { ... }, to support easier aggregation of results (#380 (comment)).

@hadley
Copy link
Member

hadley commented Mar 1, 2016

I like the idea of formalising these as fields in the expectation class (I think I'm informally tacking them on at the moment). But I do like the current symmetry of the reporter callbacks where as you get more and more detailed you get more and more arguments.

@krlmlr
Copy link
Member Author

krlmlr commented Mar 1, 2016

It's not terribly important anymore, and the reporter is a beautiful peace of ASCII art indeed:

  public = list(
    start_reporter = function() {},
    start_context =  function(context) {},
    start_test =     function(context, test) {},
    add_result =     function(context, test, result) {},
    end_test =       function(context, test) {},
    end_context =    function(context) {},
    end_reporter =   function() {}
  )

@krlmlr krlmlr closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants