Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1423
Implementation as of now has a few design choices, happy to adapt as seen fit:
R/expect-length.R
since it fits so nicely alongsideexpect_length()
, but gave it its own test file.expect_length()
, i.e.,expect_shape(x, n)
matchesexpect_length(x, n)
. Makes it easier for a series of tests to all useexpect_shape()
, instead of jumping betweenexpect_length()
andexpect_shape()
from test to testexpect_shape(., nrow=m, ncol=n)
, which is usually the same asexpect_shape(., c(m, n))
, expect whenlength(dim(.)) > 2
, a rather boutique use case of wanting to test only the first 2 dimensions of an array.