Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release candidate(s) for version 0.4.1 #222

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Release candidate(s) for version 0.4.1 #222

merged 9 commits into from
Oct 7, 2024

Conversation

florisvdh
Copy link
Member

@florisvdh florisvdh commented Sep 17, 2024 •
edited
Loading

Goal is to fix #221.

The cran_submission_0.4.1 branch essentially updates the version number and the cran-comments.md file, pulls future updates from main, and produces new release candidates.

@florisvdh
Copy link
Member Author

CRAN submission from 17 September (8ebcefe) returned below comments.

The 'Authors' one is the one I need to look better into. (The other NOTEs are old news; false positives.)

Author field differs from that derived from Authors@R

It's not something related to the updates in 0.4.1, must be due to R-dev or the CRAN checks. Prior to submission, I had seen this in devtools::check_win_devel() only.

Comments on submission 01

Dear maintainer,

package qgisprocess_0.4.1.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: https://win-builder.r-project.org/incoming_pretest/qgisprocess_0.4.1_20240917_224337/Windows/00check.log
Status: 3 NOTEs
Debian: https://win-builder.r-project.org/incoming_pretest/qgisprocess_0.4.1_20240917_224337/Debian/00check.log
Status: 3 NOTEs

Last released version's CRAN status: NOTE: 13
See: https://CRAN.R-project.org/web/checks/check_results_qgisprocess.html

CRAN Web: https://cran.r-project.org/package=qgisprocess

Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
https://stat.ethz.ch/mailman/listinfo/r-package-devel
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
https://win-builder.r-project.org/incoming_pretest/qgisprocess_0.4.1_20240917_224337/
The files will be removed after roughly 7 days.

No strong reverse dependencies to be checked.

Best regards,
CRAN teams' auto-check service

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: CRAN incoming feasibility, Result: NOTE
Maintainer: 'Floris Vanderhaeghe floris.vanderhaeghe@inbo.be'

Suggests or Enhances not in mainstream repositories:
spDataLarge
Availability using Additional_repositories specification:
spDataLarge yes https://geocompr.r-universe.dev/

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: package dependencies, Result: NOTE
Package suggested but not available for checking: 'spDataLarge'

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: DESCRIPTION meta-information, Result: NOTE
Author field differs from that derived from Authors@R
Author: 'Dewey Dunnington [aut] (https://orcid.org/0000-0002-9415-4582, Voltron Data), Floris Vanderhaeghe [aut, cre] (https://orcid.org/0000-0002-6378-6229, Research Institute for Nature and Forest (INBO)), Jan Caha [aut] (https://orcid.org/0000-0003-0165-0606), Jannes Muenchow [aut] (https://orcid.org/0000-0001-7834-4717), Antony Barja [ctb] (https://orcid.org/0000-0001-5921-2858), Robin Lovelace [ctb] (https://orcid.org/0000-0001-5679-6536), Jakub Nowosad [ctb] (https://orcid.org/0000-0002-1057-3721), Research Institute for Nature and Forest (INBO) [cph, fnd] (https://www.inbo.be/en/)'
Authors@R: 'Dewey Dunnington [aut] (ORCID: https://orcid.org/0000-0002-9415-4582, affiliation: Voltron Data), Floris Vanderhaeghe [aut, cre] (ORCID: https://orcid.org/0000-0002-6378-6229, affiliation: Research Institute for Nature and Forest (INBO)), Jan Caha [aut] (ORCID: https://orcid.org/0000-0003-0165-0606), Jannes Muenchow [aut] (ORCID: https://orcid.org/0000-0001-7834-4717), Antony Barja [ctb] (ORCID: https://orcid.org/0000-0001-5921-2858), Robin Lovelace [ctb] (ORCID: https://orcid.org/0000-0001-5679-6536), Jakub Nowosad [ctb] (ORCID: https://orcid.org/0000-0002-1057-3721), Research Institute for Nature and Forest (INBO) [cph, fnd] (https://www.inbo.be/en/)'

@florisvdh
Copy link
Member Author

Replied to CRAN team to say that I believe this is a false positive. The Authors field is auto-generated by R CMD build and the Authors@R field appears correctly formatted.

@florisvdh florisvdh mentioned this pull request Sep 21, 2024
Closed
2 tasks
@florisvdh
Copy link
Member Author

Replied again, as I got no answer so far.

@florisvdh
Copy link
Member Author

Third submission (tag 0.4.1_cran_submission_03) was accepted; version 0.4.1 is now available on CRAN.

The submission includes a nasty workaround in DESCRIPTION which makes no sense to me (028dd3b); I've reverted it already so that ORCID links on the pkgdown site work again. If this 'Authors@R' note for r-devel still comes up in future submissions, I'll engage with R-package-devel mailing list to ask for a better solution.

@florisvdh florisvdh merged commit 49ffca7 into main Oct 7, 2024
17 checks passed
@florisvdh florisvdh deleted the cran_submission_0.4.1 branch October 7, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare release 0.4.1
1 participant
@florisvdh